Francesco Romani has posted comments on this change. Change subject: vdsm: refactor all_devices using etree ......................................................................
Patch Set 3: Code-Review-1 (1 comment) not the right direction http://gerrit.ovirt.org/#/c/32453/3/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 496: def _domElement(etreeElement): Line 497: """ Line 498: Hack required in order to refactor functions in this module while Line 499: keeping other modules working as intended. Returns xml.dom.Element Line 500: instead of etree.Element We need a different approach here, to avoid the details of the XML library we used internally leak outside (e.g. to vm.py). This begs for deeper refactoring, let's discuss this separately. Line 501: """ Line 502: return xml.dom.minidom.parseString(etreeElement.tostring()) Line 503: Line 504: -- To view, visit http://gerrit.ovirt.org/32453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id83e7282319041bd5e6fdc0ef48eb2e1cd543841 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
