Saggi Mizrahi has posted comments on this change. Change subject: protocol_acceptor: Make SSL handshake asynchronous ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/33657/3/vdsm/protocoldetector.py File vdsm/protocoldetector.py: Line 222: def _process_handshake(self, socket): Line 223: try: Line 224: socket.is_handshaking = (socket.accept_ssl() == 0) Line 225: except Exception as e: Line 226: self.log.debug("Error during handshake: %s", e) > Why only debug, and why w/o the traceback? accept_ssl() is just `return m2.SSL_accept()` So traceback wouldn't help. It's not a warning since, if there are no bugs, it's OK to have handshake errors (if it's the other side's fault). Hence it's a debug log. Line 227: socket.close() Line 228: else: Line 229: if not socket.is_handshaking: Line 230: self._poller.modify(socket, self.READ_ONLY_MASK) -- To view, visit http://gerrit.ovirt.org/33657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8808633344389297fe026cd2219aa513f6f1dff Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
