Hello Nir Soffer, Federico Simoncelli, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33833
to review the following change.
Change subject: mount: fix _loopFsSpecsTimestamp global definition
......................................................................
mount: fix _loopFsSpecsTimestamp global definition
The variable _loopFsSpecsTimestamp should be defined as global before
its first use within a function.
Change-Id: Id844fd830a7ed52196d3dda91664a370ea99938b
Signed-off-by: Federico Simoncelli <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/32472
Reviewed-by: Ondřej Svoboda <[email protected]>
Reviewed-by: Nir Soffer <[email protected]>
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M vdsm/storage/mount.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/33833/1
diff --git a/vdsm/storage/mount.py b/vdsm/storage/mount.py
index 99b2299..10065a9 100644
--- a/vdsm/storage/mount.py
+++ b/vdsm/storage/mount.py
@@ -86,6 +86,7 @@
def _getLoopFsSpecs():
+ global _loopFsSpecsTimestamp
with _loopFsSpecsLock:
mtabTimestamp = os.stat(_ETC_MTAB_PATH).st_mtime
if _loopFsSpecsTimestamp != mtabTimestamp:
@@ -95,7 +96,6 @@
for opt in entry.fs_mntops:
if opt.startswith('loop='):
_loopFsSpecs[opt[len('loop='):]] = entry.fs_spec
- global _loopFsSpecsTimestamp
_loopFsSpecsTimestamp = mtabTimestamp
return _loopFsSpecs
--
To view, visit http://gerrit.ovirt.org/33833
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id844fd830a7ed52196d3dda91664a370ea99938b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
