Nir Soffer has posted comments on this change. Change subject: lvm: Cleanup lvm udev rules ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33874/1/vdsm/storage/vdsm-lvm.rules.tpl.in File vdsm/storage/vdsm-lvm.rules.tpl.in: Line 19: # "add" event is processed on coldplug only, so we need "change", too. Line 20: ACTION!="add|change", GOTO="lvm_end" Line 21: Line 22: # Filter out vgs which do not look like a vdsm vg Line 23: ENV{DM_VG_NAME}!="[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]", GOTO="lvm_end" This could be much nicer if we could replace this horrible uuid pattern with @UUID_PATTERN@, but autoconf removes "[" and "]" characters from variables values. We can use udev environment variable as a temporary variables in the udev rules, but this seems too hacky. We can also use separate string replacement (not using autoconf) for this, but it seems too much trouble. Line 24: Line 25: # Volumes used as vdsm images Line 26: ENV{DM_LV_NAME}=="[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]", OWNER:="@VDSMUSER@", GROUP:="@QEMUGROUP@"{{if chcon_hack}}, RUN+="vdsm-chcon"{{endif}}, GOTO="lvm_end" Line 27: -- To view, visit http://gerrit.ovirt.org/33874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib185a7d9a5da54036b8b0163a83ff6376b511533 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
