Dan Kenigsberg has posted comments on this change. Change subject: utils: Move functionality from storage.misc ......................................................................
Patch Set 5: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/31583/5/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 144: Line 145: Line 146: def persistFile(name): Line 147: if isOvirtNode(): Line 148: execCmd([constants.EXT_PERSIST, name], sudo=True) When exposing code to utils (which makes it within reach to plenty of users) we should make sure that it is of a higher quality. In this case we should check the return value and raise an error if persist fails. But since this implementation is to be replaced by http://gerrit.ovirt.org/#/c/33468/2 I don't mind. Line 149: Line 150: Line 151: def _parseMemInfo(lines): Line 152: """ -- To view, visit http://gerrit.ovirt.org/31583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c547e3ac2ecf19359c32f7e717ad7b098bfbca4 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
