Francesco Romani has uploaded a new change for review. Change subject: sampling: document block stats libvirt flag ......................................................................
sampling: document block stats libvirt flag Document why we use the cryptic VIR_TYPED_PARAM_STRING_OKAY. Comment-only, no code changes. Change-Id: I17698757a28848263a79e6b2b76748c9bb9b4c90 Signed-off-by: Francesco Romani <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/33967/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 48055a7..8b6c956 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -288,6 +288,15 @@ # Avoid queries from storage during recovery process return + # The usage of the cryptic flag VIR_TYPED_PARAM_STRING_OKAY + # is will be dropped in a future patch, once we are sure the + # minimum supported libvirtd server we require is ok with that. + # Quoting libvirt.h: + # """Older servers lacked the ability to handle string typed + # parameters.[...] This flag is automatically set when needed, + # [...] however, manually setting the flag can be used to + # reject servers that cannot return typed strings [...]""" + diskSamples = {} for vmDrive in self._vm.getDiskDevices(): diskSamples[vmDrive.name] = self._vm._dom.blockStatsFlags( -- To view, visit http://gerrit.ovirt.org/33967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I17698757a28848263a79e6b2b76748c9bb9b4c90 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
