Nir Soffer has uploaded a new change for review. Change subject: protocoldetector: Remove connection after handshake error ......................................................................
protocoldetector: Remove connection after handshake error Commit e414fa9ff9 added support for asynchronous SSL handshake, but did not clean up properly after handshake error. The closed connection would be removed later by the peroidical cleanup, but having a closed socket registered in the poller is not a good idea. Change-Id: Ide51d896c1e98b625fdc757042452dffd06ed9a1 Signed-off-by: Nir Soffer <[email protected]> --- M vdsm/protocoldetector.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/33982/1 diff --git a/vdsm/protocoldetector.py b/vdsm/protocoldetector.py index 612d281..0a8b822 100644 --- a/vdsm/protocoldetector.py +++ b/vdsm/protocoldetector.py @@ -224,6 +224,7 @@ socket.is_handshaking = (socket.accept_ssl() == 0) except Exception as e: self.log.debug("Error during handshake: %s", e) + self._remove_connection(client_socket) socket.close() else: if not socket.is_handshaking: -- To view, visit http://gerrit.ovirt.org/33982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ide51d896c1e98b625fdc757042452dffd06ed9a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
