Dan Kenigsberg has posted comments on this change. Change subject: assert: Replace assetion with AssertionError ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/29307/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-10-12 20:49:15 +0300 Line 6: Line 7: assert: Replace assetion with AssertionError Line 8: Line 9: If Python is run with -O flag, assertions are removed. This may casue a Is this a real problem? If someone takes the trouble to run with -O, I'd suppose he knows what he's doing. Or are you preparing to run with -O by default? Is the optimization beneficial? Line 10: useful error message to be hidden, making it harder to debug, or worse, Line 11: code invoke inside an assert will not run, changing the flow of the Line 12: "optimized" code. Line 13: -- To view, visit http://gerrit.ovirt.org/29307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c60c65b283f4343448bb9eaf6ccf2526b188db0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
