Douglas Schilling Landgraf has posted comments on this change. Change subject: utils: Use ovirt node for persist files ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/33468/3/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 56: try: Line 57: from ovirt.node.utils.fs import Config Line 58: persistFile = Config().persist Line 59: except ImportError: Line 60: persistFile = lambda name: None if ImportError, shouldn't we use ovirtfunctions.ovirt_store_config() to keep the compatible ? Line 61: Line 62: Line 63: # Buffsize is 1K because I tested it on some use cases and 1K was fastest. If Line 64: # you find this number to be a bottleneck in any way you are welcome to change -- To view, visit http://gerrit.ovirt.org/33468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice245d54497862f9fb86cb32acd13b8a790026b2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
