Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: source route: don't attempt to configure invalid values
......................................................................
net: source route: don't attempt to configure invalid values
If a DHCP server provides Vdsm with invalid ip/netmask/gateway supervdsm
logs a not-very-useful
"ipaddr, mask or gateway not received"
Instead, this patch logs dhclient's faulty information before passing it
to the source route configurator, which hopefully would provide the
local admin more clues regarding the failure.
Change-Id: I0c4719629bfdc632bbc35171489670062c6c14cb
Signed-off-by: Dan Kenigsberg <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/32416
Reviewed-by: Antoni Segura Puimedon <[email protected]>
Tested-by: Ido Barkan <[email protected]>
---
M vdsm/network/configurators/__init__.py
M vdsm/network/sourceroute.py
M vdsm/network/sourceroutethread.py
3 files changed, 17 insertions(+), 9 deletions(-)
Approvals:
Ido Barkan: Verified
Antoni Segura Puimedon: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c4719629bfdc632bbc35171489670062c6c14cb
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ido Barkan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
