Martin Polednik has posted comments on this change. Change subject: vdsm: add functionality to detach host devices ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/32389/3/vdsm/hostdev.py File vdsm/hostdev.py: Line 117: Line 118: def detach(device_name): Line 119: libvirt_device, device_params = _get_device_ref_and_params(device_name) Line 120: Line 121: if device_params['capability'] in _UNMANAGED_DEVICE_CAPS: > We were asked to det(t?)atch a device that is not pci nor usb. Why? And why For the sake of consistency - only _UNMANAGED_DEVICE_CAPS actually require the real detach (unbinding driver -> vfio bind) but having the check for other devices here removes low-level logic from VmDevice class that would otherwise have to handle this. Line 122: libvirt_device.dettach() Line 123: -- To view, visit http://gerrit.ovirt.org/32389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I530fed56831314286942b8afa62900208812bfb5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
