Francesco Romani has posted comments on this change. Change subject: mkimage: more robust content signature ......................................................................
Patch Set 6: Verified+1 verified the same way as I did for http://gerrit.ovirt.org/#/c/34201/ highltights of the log. VM creation using JSON-RPC: Thread-198::DEBUG::2014-10-20 15:18:13,979::__init__::498::jsonrpc.JsonRpcServer::(_serveRequest) Return 'VM.create' in bridge with {u'acpiEnable': u'true', u'emulatedMachine': u'rhel6.5.0', 'pid': '0', u'memGuaranteedSize': 1024, u'transparentHugePages': u'true', 'displaySecurePort': '-1', u'spiceSslCipherSuite': u'DEFAULT', u'cpuType': u'SandyBridge', u'smp': u'1', u'numaTune': {u'nodeset': u'0', u'mode': u'interleave'}, u'custom': {}, u'vmType': u'kvm', u'memSize': 1024, u'smpCoresPerSocket': u'1', u'vmName': u'b', u'nice': u'0', 'status': 'WaitForLaunch', u'bootMenuEnable': u'false', 'guestDiskMapping': {}, u'vmId': u'a4cf42d9-ad93-473a-a418-03e3fa537454', u'copyPasteEnable': u'true', 'displayIp': '192.168.1.48', 'displayPort': '-1', u'smartcardEnable': u'false', u'spiceSecureChannels': u'smain,sinputs,scursor,splayback,srecord,sdisplay,susbredir,ssmartcard', u'fileTransferEnable': u'true', 'nicModel': 'rtl8139,pv', u'keyboardLayout': u'en-us', u'kvmEnable': u'true', u'd! isplayNetwork': u'ovirtmgmt', u'devices': [{u'index': u'3', u'iface': u'ide', u'specParams': {u'vmPayload': {u'volId': u'config-2', u'file': {u'openstack/latest/meta_data.json': u'ewogICJsYXVuY2hfaW5kZXgiIDogIjAiLAogICJhdmFpbGFiaWxpdHlfem9uZSIgOiAibm92YSIs\r\nCiAgInV1aWQiIDogIjAxMTU2ZmQ3LWU4MGEtNGFhNy1iZTI1LTQ2NWIzM2E3NTM4NCIsCiAgIm1l\r\ndGEiIDogewogICAgImVzc2VudGlhbCIgOiAiZmFsc2UiLAogICAgInJvbGUiIDogInNlcnZlciIs\r\nCiAgICAiZHNtb2RlIiA6ICJsb2NhbCIKICB9Cn0=\r\n', u'openstack/latest/user_data': u'I2Nsb3VkLWNvbmZpZwpzc2hfcHdhdXRoOiB0cnVlCmRpc2FibGVfcm9vdDogMApvdXRwdXQ6CiAg\r\nYWxsOiAnPj4gL3Zhci9sb2cvY2xvdWQtaW5pdC1vdXRwdXQubG9nJwpjaHBhc3N3ZDoKICBleHBp\r\ncmU6IGZhbHNlCnJ1bmNtZDoKLSAnc2VkIC1pICcnL15kYXRhc291cmNlX2xpc3Q6IC9kJycgL2V0\r\nYy9jbG91ZC9jbG91ZC5jZmc7IGVjaG8gJydkYXRhc291cmNlX2xpc3Q6CiAgWyJOb0Nsb3VkIiwg\r\nIkNvbmZpZ0RyaXZlIl0nJyA+PiAvZXRjL2Nsb3VkL2Nsb3VkLmNmZycK\r\n'}}}, u'readonly': u'true', 'deviceType': u'disk', u'deviceId': u'266cbf09-b83e-40d1-9871-fc1b9a7212c0', u'p! ath': u'', u'device': u'cdrom', u'shared': u'false', u'type': u'disk'}, {u'device': u'qxl', u'specParams': {u'vram': u'32768', u'heads': u'1'}, 'deviceType': u'video', u'type': u'video', u'deviceId': u'3d375a79-f12a-4b99-b347-7e7a35b73281'}, {u'index': u'2', u'iface': u'ide', u'specParams': {u'path': u''}, u'readonly': u'true', 'deviceType': u'disk', u'deviceId': u'dbb18650-2c6d-4c1c-ae92-de6007f3239e', u'path': u'', u'device': u'cdrom', u'shared': u'false', u'type': u'disk'}, {u'index': 0, u'iface': u'virtio', 'reqsize': '0', u'format': u'raw', 'deviceType': u'disk', u'bootOrder': u'1', u'volumeID': u'a78809f5-9029-46f1-bd2b-8e4e48d228ae', u'imageID': u'50af34b9-5b2c-40e7-ac1f-691f7424d3fe', u'specParams': {}, u'readonly': u'false', u'domainID': u'f3b719f6-b24b-45d4-920a-1e333b3814e2', u'optional': u'false', u'deviceId': u'50af34b9-5b2c-40e7-ac1f-691f7424d3fe', u'poolID': u'00000002-0002-0002-0002-00000000023d', u'device': u'disk', u'shared': u'false', u'propagateErrors': u'off', u'type': u'disk'}, {u'nicModel': u'pv', u'macAddr': u'00:1a:4a:! 71:2e:01', u'linkActive': u'true', u'network': u'ovirtmgmt', u'bootOrder': u'2', u'filter': u'vdsm-no-mac-spoofing', u'specParams': {u'inbound': {}, u'outbound': {}}, 'deviceType': u'interface', u'deviceId': u'f6d046c7-ccd4-4642-93fd-e921f4db506d', u'device': u'bridge', u'type': u'interface'}, {u'device': u'memballoon', u'specParams': {u'model': u'virtio'}, 'deviceType': u'balloon', u'type': u'balloon', u'deviceId': u'935b0755-e9f6-4402-9ca2-c81ee2f24e8b'}, {u'index': u'0', u'specParams': {}, 'deviceType': u'controller', u'deviceId': u'97bad4c5-81c6-4ca6-8580-cbd5d0b79f70', u'device': u'scsi', u'model': u'virtio-scsi', u'type': u'controller'}, {u'device': u'virtio-serial', u'specParams': {}, 'deviceType': u'controller', u'type': u'controller', u'deviceId': u'f04db144-cae6-4028-8993-6ae5dfc1e3af'}], u'timeOffset': u'0', u'maxVCpus': u'16', 'clientIp': '', u'display': u'qxl'} virsh dumpxml shows the device(s) created OK: <devices> <emulator>/usr/libexec/qemu-kvm</emulator> <disk type='file' device='cdrom'> <driver name='qemu' type='raw'/> <source startupPolicy='optional'/> <target dev='hdc' bus='ide'/> <readonly/> <serial></serial> <alias name='ide0-1-0'/> <address type='drive' controller='0' bus='1' target='0' unit='0'/> </disk> <disk type='file' device='cdrom'> <driver name='qemu' type='raw'/> <source file='/var/run/vdsm/payload/a4cf42d9-ad93-473a-a418-03e3fa537454.0d44f30bb64a0d38a07bfa4a3ef29b83.img' startupPolicy='optional'/> <target dev='hdd' bus='ide'/> <readonly/> <serial></serial> <alias name='ide0-1-1'/> <address type='drive' controller='0' bus='1' target='0' unit='1'/> </disk> migration: Thread-181::DEBUG::2014-10-20 15:19:18,109::BindingXMLRPC::1161::vds::(wrapper) return vmMigrationCreate with {'status': {'message': 'Done', 'code': 0}, 'migrationPort': 0, 'params': {'guestFQDN': '', 'acpiEnable': 'true', 'emulatedMachine': 'rhel6.5.0', 'afterMigrationStatus': '', 'spiceSecureChannels': 'smain,sinputs,scursor,splayback,srecord,sdisplay,susbredir,ssmartcard', 'pid': '0', 'memGuaranteedSize': 1024, 'transparentHugePages': 'true', 'displaySecurePort': '-1', 'spiceSslCipherSuite': 'DEFAULT', 'cpuType': 'SandyBridge', 'custom': {}, 'pauseCode': 'NOERR', 'migrationDest': 'libvirt', 'numaTune': {'nodeset': '0', 'mode': 'interleave'}, 'smp': '1', 'vmType': 'kvm', 'memSize': 1024, 'smpCoresPerSocket': '1', 'vmName': 'b', 'nice': '0', 'username': 'Unknown', 'bootMenuEnable': 'false', 'guestDiskMapping': {}, 'vmId': 'a4cf42d9-ad93-473a-a418-03e3fa537454', 'copyPasteEnable': 'true', 'displayIp': '192.168.1.40', 'displayPort': '-1', 'smartcardEnable': 'false', 'clientIp! ': '', 'fileTransferEnable': 'true', 'nicModel': 'rtl8139,pv', 'keyboardLayout': 'en-us', 'kvmEnable': 'true', 'displayNetwork': 'ovirtmgmt', 'devices': [{'target': 1048576, 'specParams': {'model': 'virtio'}, 'alias': 'balloon0', 'deviceType': 'balloon', 'deviceId': '935b0755-e9f6-4402-9ca2-c81ee2f24e8b', 'address': {'slot': '0x07', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x0'}, 'device': 'memballoon', 'type': 'balloon'}, {'index': '0', 'alias': 'scsi0', 'specParams': {}, 'deviceType': 'controller', 'deviceId': '97bad4c5-81c6-4ca6-8580-cbd5d0b79f70', 'address': {'slot': '0x04', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x0'}, 'device': 'scsi', 'model': 'virtio-scsi', 'type': 'controller'}, {'specParams': {}, 'alias': 'virtio-serial0', 'deviceType': 'controller', 'deviceId': 'f04db144-cae6-4028-8993-6ae5dfc1e3af', 'address': {'slot': '0x05', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x0'}, 'device': 'virtio-ser! ial', 'type': 'controller'}, {'specParams': {'vram': '32768', 'heads': '1'}, 'alias': 'video0', 'deviceType': 'video', 'deviceId': '3d375a79-f12a-4b99-b347-7e7a35b73281', 'address': {'slot': '0x02', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x0'}, 'device': 'qxl', 'type': 'video'}, {'tlsPort': '5901', 'specParams': {'displayNetwork': 'ovirtmgmt', 'spiceSecureChannels': 'smain,sinputs,scursor,splayback,srecord,sdisplay,susbredir,ssmartcard', 'keyMap': 'en-us', 'displayIp': '192.168.1.40', 'copyPasteEnable': 'true'}, 'deviceType': 'graphics', 'device': 'spice', 'type': 'graphics', 'port': '5900'}, {'nicModel': 'pv', 'macAddr': '00:1a:4a:71:2e:01', 'linkActive': True, 'network': 'ovirtmgmt', 'specParams': {'inbound': {}, 'outbound': {}}, 'bootOrder': '2', 'filter': 'vdsm-no-mac-spoofing', 'alias': 'net0', 'deviceType': 'interface', 'deviceId': 'f6d046c7-ccd4-4642-93fd-e921f4db506d', 'address': {'slot': '0x03', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type': 'interface', 'name'! : 'vnet0'}, {'index': '3', 'iface': 'ide', 'name': 'hdd', 'alias': 'ide0-1-1', 'shared': 'false', 'specParams': {'vmPayload': {'volId': 'config-2', 'file': {'openstack/latest/meta_data.json': 'ewogICJsYXVuY2hfaW5kZXgiIDogIjAiLAogICJhdmFpbGFiaWxpdHlfem9uZSIgOiAibm92YSIs\nCiAgInV1aWQiIDogIjAxMTU2ZmQ3LWU4MGEtNGFhNy1iZTI1LTQ2NWIzM2E3NTM4NCIsCiAgIm1l\ndGEiIDogewogICAgImVzc2VudGlhbCIgOiAiZmFsc2UiLAogICAgInJvbGUiIDogInNlcnZlciIs\nCiAgICAiZHNtb2RlIiA6ICJsb2NhbCIKICB9Cn0=\n', 'openstack/latest/user_data': 'I2Nsb3VkLWNvbmZpZwpzc2hfcHdhdXRoOiB0cnVlCmRpc2FibGVfcm9vdDogMApvdXRwdXQ6CiAg\nYWxsOiAnPj4gL3Zhci9sb2cvY2xvdWQtaW5pdC1vdXRwdXQubG9nJwpjaHBhc3N3ZDoKICBleHBp\ncmU6IGZhbHNlCnJ1bmNtZDoKLSAnc2VkIC1pICcnL15kYXRhc291cmNlX2xpc3Q6IC9kJycgL2V0\nYy9jbG91ZC9jbG91ZC5jZmc7IGVjaG8gJydkYXRhc291cmNlX2xpc3Q6CiAgWyJOb0Nsb3VkIiwg\nIkNvbmZpZ0RyaXZlIl0nJyA+PiAvZXRjL2Nsb3VkL2Nsb3VkLmNmZycK\n'}}}, 'readonly': 'True', 'devic please note the mangling of the line breaks libvirtd is happy on DST as well: <devices> <emulator>/usr/libexec/qemu-kvm</emulator> <disk type='file' device='cdrom'> <driver name='qemu' type='raw'/> <source startupPolicy='optional'/> <target dev='hdc' bus='ide'/> <readonly/> <serial></serial> <alias name='ide0-1-0'/> <address type='drive' controller='0' bus='1' target='0' unit='0'/> </disk> <disk type='file' device='cdrom'> <driver name='qemu' type='raw'/> <source file='/var/run/vdsm/payload/a4cf42d9-ad93-473a-a418-03e3fa537454.0d44f30bb64a0d38a07bfa4a3ef29b83.img' startupPolicy='optional'/> <target dev='hdd' bus='ide'/> <readonly/> <serial></serial> <alias name='ide0-1-1'/> <address type='drive' controller='0' bus='1' target='0' unit='1'/> </disk> -- To view, visit http://gerrit.ovirt.org/34203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8dfd32eacd5c5a01d0ba27a8403a46d4bea02ab Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
