Francesco Romani has posted comments on this change.

Change subject: caps: Do not memoize CPU topology
......................................................................


Patch Set 1:

Un-draft this patch to make sure it is reviewed, when you feel it is ready.

As for the patch itself, can you expand the commit message with a few lines 
which explain why this change is needed? It may not be obvious at first glance.

I don't have significat objections codewise, but I'm concerned about the loss 
of unit tests and tests coverage refuction in general.
Any chance to have some tests back?

-- 
To view, visit http://gerrit.ovirt.org/34189
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0e87b50d4fe882240c93a0a1600e3a0cb98d443
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vdel...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdel...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to