Dan Kenigsberg has posted comments on this change. Change subject: clean dhclient processes that are left after functional tests ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/34366/3/tests/functional/dhcp.py File tests/functional/dhcp.py: Line 100: self.pid = int(pid_file.read()) Line 101: Line 102: def stop(self): Line 103: try: Line 104: os.kill(self.pid, SIGKILL) based on Toni's former comment, I suggest to send SIGTERM and os.wait() on the pid, which is the polite wait to ask dhclient to shut down. If they don't adhere to it, it's their bug. Line 105: except OSError as error: Line 106: if error.errno == ESRCH: Line 107: pass # No such process Line 108: else: -- To view, visit http://gerrit.ovirt.org/34366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I458aa38415c697d3863e173444ff921d759166a2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
