Nir Soffer has posted comments on this change. Change subject: storageServer: remove dead code from getSessionInfo ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34537/1/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 404 Line 405 Line 406 Line 407 Line 408 This looks like an optimization attempt to check first the last session we found. It would work if we replace the iteration bellow to: for session in sessions: Did you verify in git history that we never used this? If we never used it, the safest thing would be to delete this. -- To view, visit http://gerrit.ovirt.org/34537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd93fd7d0257caea60bb3981ec1a6604e0dcc723 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
