Dan Kenigsberg has submitted this change and it was merged. Change subject: openstacknet: Fix migration when using security groups ......................................................................
openstacknet: Fix migration when using security groups When migrating, the destination libvirt receives an xml already altered by before_device_create like this test one: <?xml version="1.0" encoding="utf-8"?> <interface type="bridge"> <mac address="00:1a:4a:16:01:51"/> <model type="virtio"/> <source bridge="qbrtest_port_i"/> <target dev="taptest_port_i"/> </interface> The issue is that before_device_create hooking point is not part of the migration and it is the only thing that creates the security groups bridge and the necessary veths. In order to have migration working, then, it was necessary to add a hook that on the hooking point 'before_device_migrate' does the security groups bridge and veths creation. Change-Id: Icd8a789c4565f32b32965af3966a4edd361949ea Bug-Url: https://bugzilla.redhat.com/1048880 Signed-off-by: Antoni S. Puimedon <asegu...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/34406 Reviewed-by: Francesco Romani <from...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M debian/vdsm-hook-openstacknet.install M vdsm.spec.in M vdsm_hooks/openstacknet/Makefile.am M vdsm_hooks/openstacknet/before_device_create.py A vdsm_hooks/openstacknet/before_device_migrate_destination.py M vdsm_hooks/openstacknet/openstacknet_utils.py 6 files changed, 142 insertions(+), 47 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34406 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd8a789c4565f32b32965af3966a4edd361949ea Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches