Saggi Mizrahi has posted comments on this change. Change subject: cache: Add caching decorator with invalidation ......................................................................
Patch Set 1: Code-Review-1 There is already a memoized() in utils.py. There should only be one. Please either unify both or name them so that users know when to use either. Also, this is infra so the module should be under /lib/vdsm/infra/ with it's tests next to it. Also add entry in the documentation index. Just look at how zombiereaper is maintained for an example. Further more, I understand that the term in\validate is because you are talking about the cache, but I think having: @memoized(update_on=file_modified("/etc/passwd")) Gives a better explanation on expected behaviour. -- To view, visit http://gerrit.ovirt.org/34709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dd8fb29d94286e3e3a3e29b8218501cbdc5c018 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches