Saggi Mizrahi has posted comments on this change. Change subject: signals: Handle signals to non-main threads ......................................................................
Patch Set 18: Code-Review-1 (2 comments) Move to /lib/vdsm/infra/ http://gerrit.ovirt.org/#/c/29392/18/lib/vdsm/sigutils.py File lib/vdsm/sigutils.py: Line 85: if timeout is not None: Line 86: timeout *= 1000 Line 87: Line 88: try: Line 89: cleanup = [] != _signal_poller.poll(timeout) add () and consider changing to cleanup = (not _signal_poller.poll(timeout)) Line 90: except select.error as e: Line 91: if e[0] != errno.EINTR: Line 92: raise Line 93: cleanup = True Line 112: Line 113: Line 114: def _empty_pipe(): Line 115: while len(_read(_signal_read_fd, 128)) == 128: Line 116: pass > Now we can inline _read here: Splitting a function to two logical parts is OK. One part is about *how* you read the other is about *what* you read. -- To view, visit http://gerrit.ovirt.org/29392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
