Francesco Romani has posted comments on this change. Change subject: vm: safe(r) Vm.conf update in creation thread ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/34813/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1396: # The new/old type parameter will be distinguished Line 1397: # by existence/absence of the 'devices' key Line 1398: Line 1399: try: Line 1400: # while this code is running, Vm is queryable for status(), > Michal, you may be right that engine should not query the status here while Indeed the VDSM code must be correct, and at the moment it is not, so this patch is needed. But from a flow perspective, Michal's suggestions makes a lot of sense. I'll post a followup patch once this is in, so we can focus on a more correct flow. Line 1401: # thus we must fix devices in an atomic way, hence the deepcopy Line 1402: with self._confLock: Line 1403: devConf = deepcopy(self.conf['devices']) Line 1404: except KeyError: -- To view, visit http://gerrit.ovirt.org/34813 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9dee2aa01b2c231b99e02a879dcfbd7ecc7f70a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
