Ido Barkan has posted comments on this change.

Change subject: change qosOutbound for a nested 'hostQos':{'out': 
bandwidth_params}
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/33165/5/vdsm/network/configurators/__init__.py
File vdsm/network/configurators/__init__.py:

Line 115:         self.configApplier.removeLibvirtNetwork(network)
Line 116: 
Line 117:     def configureQoS(self, hostQos, top_device):
Line 118:         out = hostQos.get('out')
Line 119:         if out is not None:
why being defensive here and not blow up? This is not how we handle the rest of 
the information.
Line 120:             qos.configure_outbound(out, top_device)
Line 121: 
Line 122:     def removeQoS(self, top_device):
Line 123:         qos.remove_outbound(top_device)


-- 
To view, visit http://gerrit.ovirt.org/33165
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I158af66fb98e2c1384aaf1f9e90b208ab01097a5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ido Barkan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to