Dan Kenigsberg has posted comments on this change. Change subject: fix broken TestConfigNetwork.testAddNetworkValidation ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/34868/1/tests/configNetworkTests.py File tests/configNetworkTests.py: Line 90: 'fakebr1': {'ports': ['bond00']}, Line 91: 'fakebr2': {'ports': ['eth7.1']} Line 92: }, Line 93: 'bondings': { Line 94: 'bond00': { what is the purpose of this change? could you explain how/whether it is related to unbreaking the tests? Line 95: 'slaves': ['eth5', 'eth6'], Line 96: 'cfg': {'BONDING_OPTS': 'mode=802.3ad miimon=150'} Line 97: } Line 98: } -- To view, visit http://gerrit.ovirt.org/34868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14a8138b239c1275c67eba6888115d33bf596f05 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
