Petr Horáček has posted comments on this change.

Change subject: netlink: ignore_enodev parameter in *_info
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/34925/1/lib/vdsm/netlink/link.py
File lib/vdsm/netlink/link.py:

Line 68:             info['device'] = 
_link_index_to_name(underlying_device_index,
Line 69:                                                  cache=cache)
Line 70:         except IOError as err:
Line 71:             if err.errno == errno.ENODEV and ignore_enodev:
Line 72:                 info['device_index'] = underlying_device_index
maybe we could return *_index in every case
Line 73:             else:
Line 74:                 raise
Line 75: 
Line 76:     master_index = _rtnl_link_get_master(link)


-- 
To view, visit http://gerrit.ovirt.org/34925
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41dfc7178144ae35a6b5bb52c185a337c94138ba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to