Saggi Mizrahi has posted comments on this change. Change subject: tool: change configure verb logic. ......................................................................
Patch Set 2: Code-Review+2 (1 comment) If passed pep8 http://gerrit.ovirt.org/#/c/34100/2/tests/toolTests.py File tests/toolTests.py: Line 252: pass Line 253: c, args = Thing(), Thing() Line 254: setattr(c, 'name', lambda: "Mock") Line 255: Line 256: for (isconfigured, isvalid, force, expected) in ( Does this pass pep8? Line 257: (YES, True, True, False), Line 258: (YES, True, False, False), Line 259: (YES, False, True, InvalidConfig), Line 260: (YES, False, False, InvalidConfig), -- To view, visit http://gerrit.ovirt.org/34100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I166fbae855ebff93ef84270f11b74f32fcc115c2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
