Nir Soffer has posted comments on this change. Change subject: qemuimg: add backing file to convert ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/33354/4/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 175: cmd.extend(("-O", dstFormat)) Line 176: if dstFormat == FORMAT.QCOW2 and _supports_qcow2_compat('convert'): Line 177: options.append('compat=' + QCOW2_COMPAT) Line 178: Line 179: if backing: Does backing work if dstFormat is not qcow2? Line 180: if not os.path.isabs(backing): Line 181: cwdPath = os.path.dirname(srcImage) Line 182: Line 183: options.append('backing_file=' + str(backing)) -- To view, visit http://gerrit.ovirt.org/33354 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d6f254f5750fa249809469ecc764a73c91914d4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
