Dan Kenigsberg has posted comments on this change. Change subject: Fix ballooning behaviour of freshly received VM ......................................................................
Patch Set 2: Code-Review-1 (1 comment) -1 for visibility http://gerrit.ovirt.org/#/c/34887/2/tests/vmTests.py File tests/vmTests.py: Line 1505: testvm._dom = fake.Domain( Line 1506: virtError=libvirt.VIR_ERR_NO_DOMAIN) Line 1507: mock_stats_thread = vm.VmStatsThread(testvm) Line 1508: res = mock_stats_thread.get() Line 1509: self.assertIn('balloonInfo', res) I'd expect that self.assertNotIn('balloon_cur', res['balloonInfo']) should succeed here, too. Right? Why did you drop it instead of changing it here, too? Line 1510: Line 1511: def testMultipleGraphicDeviceStats(self): Line 1512: devices = [{'type': 'graphics', 'device': 'spice', 'port': '-1'}, Line 1513: {'type': 'graphics', 'device': 'vnc', 'port': '-1'}] -- To view, visit http://gerrit.ovirt.org/34887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If44c8e9d65b7221b2dec5fdd1f2d7d4343f7aeaa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
