Dan Kenigsberg has posted comments on this change. Change subject: netinfo, tool: Make the bonding defaults a proper Python file ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/33890/6/tests/netinfoTests.py File tests/netinfoTests.py: Line 312: bonds.flush() Line 313: Line 314: try: # no error is anticipated but let's make sure we can clean up Line 315: self.assertEqual(_getBondingOptions(bondName), {}, Line 316: "please run vdsm-tool dump-bonding-defaults") Please change text to: "this test fails when a new bonding option is added to the kernel. Please run `vdsm-tool dump-bonding-defaults` and retest" Please place this suggestion in its own patch. Line 317: Line 318: with open(BONDING_OPT % (bondName, 'miimon'), 'w') as opt: Line 319: opt.write(INTERVAL) Line 320: -- To view, visit http://gerrit.ovirt.org/33890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f62c0052e42ea23cc06e64fc9e158bf5dc4258 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
