Antoni Segura Puimedon has uploaded a new change for review.
Change subject: network: Make vdsmd delNetwork use supervdsmd setupNetworks
......................................................................
network: Make vdsmd delNetwork use supervdsmd setupNetworks
delNetwork is part of a very old and deprecated API that we have to
eventually shed off in the next major release. It makes sense to
just make an adapter so that we can simplify network.api to keep
a single entry point.
Change-Id: Ic1ddb7bdd2128c35a3d8198a5ca2850aea974c38
Signed-off-by: Antoni S. Puimedon <asegu...@redhat.com>
---
M vdsm/API.py
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/35310/1
diff --git a/vdsm/API.py b/vdsm/API.py
index 3cdf789..4cdfbc5 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1439,7 +1439,7 @@
finally:
self._cif._networkSemaphore.release()
- def delNetwork(self, bridge, vlan=None, bond=None, nics=None,
+ def delNetwork(self, network, vlan=None, bond=None, nics=None,
options=None):
"""Delete a network from this vds."""
if options is None:
@@ -1477,7 +1477,9 @@
self._cif._netConfigDirty = True
try:
- supervdsm.getProxy().delNetwork(bridge, options)
+ supervdsm.getProxy().setupNetworks(
+ {network: {'remove': True, 'implicitBonding': True}},
+ {}, {'connectivityCheck': False})
except ConfigNetworkError as e:
self.log.error(e.message, exc_info=True)
return {'status': {'code': e.errCode, 'message': e.message}}
--
To view, visit http://gerrit.ovirt.org/35310
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1ddb7bdd2128c35a3d8198a5ca2850aea974c38
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
