Hello Ondřej Svoboda, Antoni Segura Puimedon,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/35317
to review the following change.
Change subject: netinfo.getIpInfo: handle slashless address
......................................................................
netinfo.getIpInfo: handle slashless address
Apparently, 32 bit prefix is not reported within the address field.
Change-Id: I44f0658dd337f6930900985f227302f52c7add0d
Signed-off-by: Dan Kenigsberg <dan...@redhat.com>
Bug-Url: https://bugzilla.redhat.com/1165210
Reviewed-on: http://gerrit.ovirt.org/34137
Reviewed-by: Ondřej Svoboda <osvob...@redhat.com>
Reviewed-by: Antoni Segura Puimedon <asegu...@redhat.com>
---
M lib/vdsm/netinfo.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/35317/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index 74c9f6c..c299dd4 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -325,7 +325,7 @@
if addr['family'] == 'inet':
ipv4addrs.append(addr['address'])
if 'secondary' not in addr['flags']:
- ipv4addr, prefix = addr['address'].split('/')
+ ipv4addr = addr['address'].split('/')[0]
ipv4netmask = prefix2netmask(addr['prefixlen'])
else:
ipv6addrs.append(addr['address'])
--
To view, visit http://gerrit.ovirt.org/35317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I44f0658dd337f6930900985f227302f52c7add0d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
