Yaniv Bronhaim has submitted this change and it was merged. Change subject: vm: fix getVmPolicy return type. ......................................................................
vm: fix getVmPolicy return type. in case of error, getVmPolicy will return a VDSM API return value, which may confuse the caller. This patch makes getVmPolicy returns explicitely None on error, and let the caller handle this condition and bail out correctly. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120246 Change-Id: I4c1d79283ee2de4a5dcf54f3544ec346c68837e1 Signed-off-by: Francesco Romani <from...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/29930 Reviewed-by: Martin Sivák <msi...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/30072 Tested-by: Martin Sivák <msi...@redhat.com> --- M tests/vmTests.py M vdsm/virt/vm.py 2 files changed, 26 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c1d79283ee2de4a5dcf54f3544ec346c68837e1 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
