Francesco Romani has posted comments on this change. Change subject: task: add the support for abort_callback ......................................................................
Patch Set 3: (1 comment) VERY preliminary review - good chance for me to learn more about the task framework http://gerrit.ovirt.org/#/c/33689/3/vdsm/storage/task.py File vdsm/storage/task.py: Line 1231: Line 1232: for callback_weakref in self.abort_weakrefs: Line 1233: callback = callback_weakref() Line 1234: Line 1235: if callback is None: Is this safe or there is a risk of race? (I don't remember the internals of weakref so well) Line 1236: continue Line 1237: Line 1238: try: Line 1239: callback() -- To view, visit http://gerrit.ovirt.org/33689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib82289e28e5ad9ea142850c31ccff3366b8397dc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
