Dan Kenigsberg has posted comments on this change. Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet ......................................................................
Patch Set 19: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/31529/19/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 150: def _resolveIscsiIface(ifaceName, initiatorName, netIfaceName): Line 151: if not ifaceName: Line 152: return iscsi.IscsiInterface('default') Line 153: Line 154: for iface in iscsi.iterateIscsiInterfaces(): if iface.name = ifaceName already exists, but lacks the requested netIfaceName, we have a problem that we should not ignore, not blindly overwrite. I *think* that the solution would be to parse iscsiadm -m iface list better, and extract the netIfaceName from it. At the moment iscsiadm.iface_list() ignores all but the iscsi interface name. Instead, it should return a named tuple of all extracted info # iscsiadm -m iface list default tcp,<empty>,<empty>,<empty>,<empty> iser iser,<empty>,<empty>,<empty>,<empty> eth1 tcp,<empty>,<empty>,SAN1,<empty> eth2 tcp,<empty>,<empty>,SAN2,<empty> Please add this parsing in a separate patch, that includes its own unit test. Line 155: if iface.name == ifaceName: Line 156: iface.netIfaceName = netIfaceName Line 157: return iface Line 158: -- To view, visit http://gerrit.ovirt.org/31529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <apa...@redhat.com> Gerrit-Reviewer: Amador Pahim <apa...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: jian wang <wjia...@gmail.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
