Nir Soffer has posted comments on this change. Change subject: jsonrpc: have simplejson as soft dependency ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/35354/2/lib/vdsm/compat.py File lib/vdsm/compat.py: Line 35: json # make pyflakes happy Line 36: except ImportError: Line 37: # no big deal, fallback to standard libary Line 38: import json Line 39: json # yep, this is needed twice. The "make pyflakes happy" lines are not needed. Since version 0.73 pyflakes does not issue these bogus warnings. We should require current pyflakes version, available from: https://pypi.python.org/pypi/pyflakes/0.8.1 This is a development tool, and there is no reason to depend on the old broken version kept in EL repositories. -- To view, visit http://gerrit.ovirt.org/35354 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11c05cff5b1cc3727653fa4ce210a76fcadf5628 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
