Dan Kenigsberg has submitted this change and it was merged. Change subject: avoid reading ifcfg files in netinfo ......................................................................
avoid reading ifcfg files in netinfo getting runtime network information is better via quering more standard netinfo api's rather than reading ifcfg configuration files which is more error prone. We need to confine reading ifcfg files only in the context of dealing with the ifcfg configurator. Change-Id: I28e2084a15e1f6cc0cb4f20e83d7751fd8ffe37f Signed-off-by: ibarkan <ibar...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/35043 Reviewed-by: Ondřej Svoboda <osvob...@redhat.com> Tested-by: Dan Kenigsberg <dan...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M lib/vdsm/netinfo.py M tests/netinfoTests.py M vdsm/network/api.py 3 files changed, 3 insertions(+), 98 deletions(-) Approvals: Ondřej Svoboda: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35043 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28e2084a15e1f6cc0cb4f20e83d7751fd8ffe37f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
