Dan Kenigsberg has posted comments on this change.

Change subject: hba: Rescan using SCSI layer
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/34245/5/vdsm/storage/fc-scan
File vdsm/storage/fc-scan:

Line 66:             log.debug("Scanning %s", path)
Line 67:             start = time.time()
Line 68:             fd = os.open(path, os.O_WRONLY)
Line 69:             try:
Line 70:                 os.write(fd, "- - -")
> Depends on the python version. There isn't really a way of knowing what wou
We still need to support Python 2.6 (on el6).
Line 71:             finally:
Line 72:                 os.close(fd)
Line 73:             self.succeeded = True
Line 74:             elapsed = time.time() - start


-- 
To view, visit http://gerrit.ovirt.org/34245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7deb3047f1b75c4c65d59602b908835515290993
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to