Adam Litke has posted comments on this change. Change subject: storage: Search only the current image for children ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35096/1/vdsm/storage/fileVolume.py File vdsm/storage/fileVolume.py: Line 360: Line 361: def getChildren(self): Line 362: """ Return children volume UUIDs. Line 363: Line 364: Children will always belong to the same image as this volume. > Is that true to template volumes, too? That's what StorageDomain.getAllVolumes() is for. The image that contains a template volume must have only that one volume. For images that derive from the template, the template volume is hardlinked into the directory. I've checked the callers of getChildren and none should be confused by a template since either they first check for volume.isShared() or the context only happens for non-template volumes (ie. Live Merge). Line 365: """ Line 366: domPath = self.imagePath.split('images')[0] Line 367: metaPattern = os.path.join(domPath, 'images', self.imgUUID, '*.meta') Line 368: metaPaths = oop.getProcessPool(self.sdUUID).glob.glob(metaPattern) -- To view, visit http://gerrit.ovirt.org/35096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ef9012cee3a8cb891926510c10ecc47b7cddaa1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
