Nir Soffer has posted comments on this change. Change subject: multipath: use backup files instead of rotateFiles ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/34077/4/vdsm/storage/multipath.py File vdsm/storage/multipath.py: Line 181: supported state. The original configuration, if any, is saved Line 182: """ Line 183: if os.path.exists(MPATH_CONF): Line 184: backup = MPATH_CONF + '.' + time.strftime("%Y%m%d%H%M") Line 185: shutil.copyfile(MPATH_CONF, backup) This will not work because we run as vdsm, and we cannot add files in /etc. You can fix this by running cp - but since this is part of moving the configuration to vdsm-tool, It is better to make this tiny change in the next patch. Line 186: utils.persist(backup) Line 187: Line 188: with tempfile.NamedTemporaryFile() as f: Line 189: f.write(MPATH_CONF_TEMPLATE % {'scsi_id_path': _scsi_id.cmd}) -- To view, visit http://gerrit.ovirt.org/34077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96a9251ebc852fcdf39239ba50f43dd2343b83a6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
