Nir Soffer has posted comments on this change. Change subject: Arranging format of configure flags to avoid conflicts later ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35578/1/vdsm.spec.in File vdsm.spec.in: Line 678: %if 0%{?enable_autotools} Line 679: autoreconf -if Line 680: %endif Line 681: %configure %{?with_hooks:--enable-hooks} \ Line 682: %{?with_chown_hack:--enable-chown-hack} I think this will be less fragile: %configure %{?with_hooks:--enable-hooks} \ %{?with_chown_hack:--enable-chown-hack} \ (empty line) Line 683: make Line 684: # Setting software_version and software_revision in dsaversion.py Line 685: baserelease=`echo "%{release}" | sed 's/\([0-9]\+\(\.[0-9]\+\)\?\).*/\1/'` Line 686: baseversion=`echo "%{version}" | sed 's/\([0-9]\+\(\.[0-9]\+\)\?\).*/\1/'` -- To view, visit http://gerrit.ovirt.org/35578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8deb5b4f32a8c0ef002758be714d15f8514a205b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
