Genadi Chereshnya has posted comments on this change.

Change subject: netinfo: Displays active slave for the bond in getVdsCaps 
vdsmapi-schema: Adding Active slave support networkTests: Test to check if 
active slave exists
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.ovirt.org/#/c/32915/7/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 769: # Information about a ethernet bond device
Line 770: #
Line 771: # @slaves:      A list of devices that are enslaved to the bond device
Line 772: #
Line 773: # @active_slave: Active slave of the bond if exists, '' otherwise
> Please align beginning of argument descriptions in line.
Done
Line 774: #
Line 775: # @bootproto4:  The protocol used to set up the network. Reported 
values are
Line 776: #               "dhcp" if a DHCPv4 client was used, 'none' if set up 
manually.
Line 777: #               (Added in version 4.16.0.)


Line 798: # Since: 4.10.0
Line 799: ##
Line 800: {'type': 'NetInfoBond',
Line 801:  'data': {'slaves': ['str'], 'active_slave': 'str','bootproto4': 
'str',
Line 802:           'addr': 'str', 'netmask': 'str', 'ipv4addrs': ['str'],
> Please align data arguments in line.
Done
Line 803:           'ipv6addrs': ['str'], 'hwaddr': 'str', 'cfg': 'StringMap',
Line 804:            'mtu': 'uint', 'opts': 'StringMap'}}
Line 805: 
Line 806: ##


-- 
To view, visit http://gerrit.ovirt.org/32915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c40755c361523a28cbd68af110e3b20cb9ae25
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcher...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Genadi Chereshnya <gcher...@redhat.com>
Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com>
Gerrit-Reviewer: Meni Yakove <myak...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to