Dan Kenigsberg has posted comments on this change. Change subject: move _netinfo and libvirt_nets decleration right before it's used ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35687/1/vdsm/network/api.py File vdsm/network/api.py: Line 658: Line 659: # gather any changes that could have been done by the hook scripts Line 660: networks = results['request']['networks'] Line 661: bondings = results['request']['bondings'] Line 662: options = results['request']['options'] but by this, other assignments are moved further away of their usage... I don't really understand the benefit. Line 663: Line 664: libvirt_nets = netinfo.networks() Line 665: _netinfo = netinfo.NetInfo(_netinfo=netinfo.get( Line 666: netinfo._libvirtNets2vdsm(libvirt_nets))) -- To view, visit http://gerrit.ovirt.org/35687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c49201eef9dace3dba8944440989a96c3300442 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches