Ido Barkan has posted comments on this change. Change subject: netconf_persistence: teach PersistentConfig to atomically store itself ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35709/1/lib/vdsm/netconfpersistence.py File lib/vdsm/netconfpersistence.py: Line 223: def _nano_timestamp(): Line 224: return ('%.20f' % time.time()).replace('.', '')[:19] Line 225: Line 226: Line 227: def _cleanupPersistence(keep=()): this method is never used, not even in dependent changes Line 228: """Cleans up CONF_PERSIST_DIR from netconfs not in 'keep'""" Line 229: for path in glob.iglob(os.path.dirname(CONF_PERSIST_NETCONF_DIR) + '.*'): Line 230: if path in keep: Line 231: continue -- To view, visit http://gerrit.ovirt.org/35709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida957b6c68607743b9efa85f4263451c955b398a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
