Sandro Bonazzola has posted comments on this change. Change subject: sosreport: remove Base class ......................................................................
Patch Set 1: (1 comment) I would still prefer having 2 separate files avoiding this kind of workaround. http://gerrit.ovirt.org/#/c/35759/1/vdsm/sos/vdsm.py.in File vdsm/sos/vdsm.py.in: Line 42: # keep plugin's name for compatibility. Line 43: config = _importVdsmPylibModule('config').config Line 44: Line 45: Line 46: class vdsm(Plugin, RedHatPlugin): I would have expected an error like: TypeError: Error when calling the metaclass bases duplicate base class sos.plugintools.PluginBase looks weird it worked. Line 47: """VDSM server related information Line 48: """ Line 49: Line 50: optionList = [("logsize", 'max size (MiB) to collect per log file', '', -- To view, visit http://gerrit.ovirt.org/35759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44816fdfe3197d655dda905c73a50e7c398b2e44 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
