Yeela Kaplan has posted comments on this change.

Change subject: sosreport: Don't try to collect info from sockets
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/35513/1/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:

Line 138:         )
Line 139: 
Line 140:     def _addVdsmRunDir(self):
Line 141:         """Add everything under /var/run/vdsm except possibly 
confidential
Line 142:         sysprep vfds and except for sockets"""
> English:
Done
Line 143: 
Line 144:         import glob
Line 145: 
Line 146:         for f in glob.glob("@VDSMRUNDIR@/*"):


Line 144:         import glob
Line 145: 
Line 146:         for f in glob.glob("@VDSMRUNDIR@/*"):
Line 147:             if not f.endswith('.vfd') and not 
f.endswith('/isoUploader') \
Line 148:                     and not f.endswith('/storage') and not 
f.endswith('.sock'):
> maybe better something like:
Done


-- 
To view, visit http://gerrit.ovirt.org/35513
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2aa8df2a8d16c7a3468cd7cad21fe598b33b8500
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to