Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: fix HostStatsThread tests ......................................................................
tests: fix HostStatsThread tests In commit 4567f368bc3b initial tests for HostStatsThread were added. Unfortunately, the patch was verified on branch, not on master, so master branch broke when the patch got merged. The mistake slipped into because * the parent patch contained the code which made the test work ok, and was abandoned (see below). * 4567f368bc3b applied cleanly against mastr. This followup patch fixes that in the following way - mark test as broken: the existing behaviour is *not* to continue in presence of errors - see http://gerrit.ovirt.org/#/c/29401/ abandoned for that reason. - wrap a real HostSample to be more correct - add a timeout to avoid hang indefinitely. Change-Id: Iefeacf5f105384040b4a81f9835faa1fa5033c07 Signed-off-by: Francesco Romani <from...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/35764 Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M tests/samplingTests.py 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/35764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefeacf5f105384040b4a81f9835faa1fa5033c07 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
