Ondřej Svoboda has posted comments on this change. Change subject: networkTests: Extend a test to also consider DHCPv6 ......................................................................
Patch Set 37: Verified+1 (1 comment) The test runs and passes on my F20 VM. http://gerrit.ovirt.org/#/c/30532/37/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 425: Line 426: def assertAddrInRange(self, addrs, addr_to_int=_ipv4_to_int, Line 427: range_from=DHCP_RANGE_FROM, range_to=DHCP_RANGE_TO): Line 428: passes = (addr_to_int(range_from) <= addr_to_int(addr) <= Line 429: addr_to_int(range_to) for addr in addrs) This is wasteful of course but I suppose I can amend it in a follow-up patch: range_from = addr_to_int(range_from) range_to = addr_to_int(range_to) passes = (range_from <= addr_to_int(a) <= range_to for a in addrs) Line 430: self.assertTrue(any(passes), 'no address {0} in expected range'.format( Line 431: addrs)) Line 432: Line 433: def testLegacyBonds(self): -- To view, visit http://gerrit.ovirt.org/30532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5d821edd54681a7a8c1013a90af61ae835baa39 Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
