Francesco Romani has posted comments on this change. Change subject: hostdev: make caps in listByCaps truly optional ......................................................................
Patch Set 1: (1 comment) possible documentation improvement. Looks fine otherwise. http://gerrit.ovirt.org/#/c/35867/1/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3798: # Line 3799: # Refresh and get information about devices available on the host Line 3800: # Line 3801: # @caps: @optional List of capabilities of devices to fetch Line 3802: # Empty means all device capabilities. I'd like to have this documentation rephrased. here 'caps' seems to behave like a filter to fetch only devices which have the given capabilities. No filter means 'everything'. Line 3803: # Line 3804: # Returns: Line 3805: # A list of devices on the host Line 3806: # -- To view, visit http://gerrit.ovirt.org/35867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc4f5ff217a12f0ffe3d75eec1e6c25c6d211fd7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
