Dan Kenigsberg has posted comments on this change. Change subject: libnl: non-existing link returns exception instead of None ......................................................................
Patch Set 15: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/34690/15/lib/vdsm/netlink/link.py File lib/vdsm/netlink/link.py: Line 26: from . import _char_proto, _int_char_proto, _int_proto, _void_proto Line 27: from . import LIBNL_ROUTE, _nl_geterror, _pool Line 28: from . import _addr_to_str, CHARBUFFSIZE Line 29: Line 30: _NLE_NODEV = 31 # libnl/incluede/netlink/errno.h Why not define it with the rest on NLE codes, inside the function using it? Line 31: Line 32: Line 33: def get_link(name): Line 34: """Returns the information dictionary of the name specified link.""" -- To view, visit http://gerrit.ovirt.org/34690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cf5c7d1cb89bb77402b6e3d23fb0e76f06e122e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
