Dan Kenigsberg has submitted this change and it was merged. Change subject: Move multipath configuration to vdsm-tool configurator ......................................................................
Move multipath configuration to vdsm-tool configurator Previously multipath is reconfigured on each vdsm service restart. multipath.conf should not be changed since important changes done by the sysadmin are needed and might be overwritten. vdsm will fail to start if multipath configuration is required. Multipath will be reconfigured only on user demand using "vdsm-tool configure --module multipath". as part of the move to using vdsm tool configurator for multipath, we want to consolidate the configuration of multipath with other configurators, such as libvirt. Rotating the configuration file will end up deleting the original multipath conf file for the user, - pre vdsm installation. So we'll use backup files with timestamp instead of rotation. Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1076531 Signed-off-by: Yeela Kaplan <ykap...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/30909 Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M lib/vdsm/tool/configurator.py M lib/vdsm/tool/configurators/Makefile.am A lib/vdsm/tool/configurators/multipath.py M vdsm.spec.in M vdsm/storage/hsm.py M vdsm/storage/multipath.py M vdsm/supervdsmServer 7 files changed, 198 insertions(+), 140 deletions(-) Approvals: Yeela Kaplan: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
