Amador Pahim has posted comments on this change. Change subject: Handle iscsi iface.net_ifacename for existing iface ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/35976/2/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line 382: def update(self): Line 383: # If this fails mid operation we get a partially updated interface. Line 384: # Suggestions are welcome. Line 385: for key, value in self._conf.iteritems(): Line 386: if value is None or value == '<empty>' \ > where does '<empty>' come from? This one comes from iscsiadm.iface_info(), called by IscsiInterface._load(). But you're right, let me hide this one in iscsiadm as well. Line 387: or key == 'iface.iscsi_ifacename': Line 388: continue Line 389: Line 390: iscsiadm.iface_update(self.name, key, value) -- To view, visit http://gerrit.ovirt.org/35976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18c2b92a75ee3bcbbcc546e2bfa4f133a5f9ad22 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
