Petr Horáček has posted comments on this change. Change subject: remove needless parameter ......................................................................
Patch Set 6: -Code-Review (1 comment) http://gerrit.ovirt.org/#/c/35913/6/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 883: def testSetupNetworksConvertVlanNetBridgeness(self): Line 884: """Convert a bridged networks to a bridgeless one and viceversa""" Line 885: Line 886: def setupNetworkBridged(bridged): Line 887: networks = {NETWORK_NAME: dict(vlan=VLAN_ID, nic=nics[0], > Does it really work this way? You can't use it if it's not defined or passe I was so curious so i tried it, wow Line 888: bridged=bridged)} Line 889: status, msg = self.vdsm_net.setupNetworks(networks, {}, Line 890: NOCHK) Line 891: self.assertEqual(status, SUCCESS, msg) -- To view, visit http://gerrit.ovirt.org/35913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1dd97c1a64ef3dd9deb96e65ed5ee9f31d26a443 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
