Francesco Romani has posted comments on this change. Change subject: jsonrpc: VM_updateVmPolicy ......................................................................
Patch Set 3: Code-Review+1 (1 comment) this patch makes things consistent, so good to have. http://gerrit.ovirt.org/#/c/35556/3/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 465: 'VM_setCpuTuneQuota': {'ret': 'taskStatus'}, Line 466: 'VM_setNumberOfCpus': {'ret': 'vmList'}, Line 467: 'VM_setIoTune': {'ret': 'taskStatus'}, Line 468: 'VM_updateDevice': {'ret': 'vmList'}, Line 469: 'VM_updateVmPolicy': {'ret': 'taskStatus'}, > Doesn't seem a taskStatus the same way as it is in Ok, got it (simple enough: just look at the schema). I may be still right and perhaps TaskStatus is not the right return value, but this is material for a different patch. Line 470: 'Volume_copy': {'ret': 'uuid'}, Line 471: 'Volume_create': {'ret': 'uuid'}, Line 472: 'Volume_delete': {'ret': 'uuid'}, Line 473: 'Volume_getInfo': {'ret': 'info'}, -- To view, visit http://gerrit.ovirt.org/35556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39c3e0a675b0574c25a2602f672ed6a36a05547c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
